refactor(op-store)!: pass ops as bytes to op store #71
+80
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jost-s
force-pushed
the
refactor/pass-op-bytes-to-op-store
branch
from
3c4aca5 to
2882924
Compare
ThetaSinner
previously approved these changes
Jan 14, 2025
jost-s
force-pushed
the
refactor/pass-op-bytes-to-op-store
branch
from
2882924 to
0e74e52
Compare
They weren't, deleted the Kitsune2MemoryOp conversions. |
jost-s
force-pushed
the
refactor/pass-op-bytes-to-op-store
branch
from
0e74e52 to
ade70b7
Compare
|
Apologies, I addressed another windows test flake. Windows getting slower by the day obviously. |
ThetaSinner
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the op store trait to take opaque bytes instead of
MetaOps when processing incoming ops. I think that's already it. Retrieving ops from the store should still beMetaOps.